Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Reorganisation & fixes for the next release #93

Open
3 tasks
garyb opened this issue Apr 17, 2017 · 6 comments
Open
3 tasks

Reorganisation & fixes for the next release #93

garyb opened this issue Apr 17, 2017 · 6 comments

Comments

@garyb
Copy link
Member

garyb commented Apr 17, 2017

This won't necessarily happen in the near future, since it will break a lot of stuff, but there are a bunch of things that should be updated / made consistent:

  • Use a consistent URL newtype throughout
  • Rename DOM.Websocket to DOM.WebSocket
  • MessageEvent is under websockets, but is more generally applicable

(& will probably extend over time)

@natefaubion
Copy link
Contributor

I think there are a few APIs that should be moved out into their own library within purescript-web.

  • DOM.XHR
  • DOM.WebStorage
  • DOM.WebSocket
  • DOM.File

@chexxor
Copy link
Contributor

chexxor commented Nov 2, 2017

I've got DOM.HTML.Navigator.Geolocation in my chexxor/purescript-dom-geolocation - use-aff branch - DOM/HTML/Navigator/Geolocation.purs Idk if it needs a rename.
Would that belong here as "purescript-web/purescript-dom-geolocation"?

@gabejohnson
Copy link

gabejohnson commented Feb 2, 2018

I'm planning to move websocket out to https://github.com/purescript-web/purescript-web-socket. The same with a bunch of other Web APIs. I was just waiting on the removal of effect rows from Eff.

My instinct is to have a PR for Eff -> Effect and then one for each new lib.

Thoughts?

@garyb
Copy link
Member Author

garyb commented Feb 2, 2018

So make an -> Effect PR in here, and then break stuff out after you mean? I guess that makes sense, in case there are any changes during that that need thinking about.

I'll perhaps merge into a new branch on here though, until we're ready to release the new "web / dom ecosystem" based on Effect though, rather than having it in master in the mean time. Sound good?

@gabejohnson
Copy link

Sounds good. I'll submit the PR. I can set it to merge with master, or if you want to make the new branch first I'll wait.

@garyb
Copy link
Member Author

garyb commented Feb 2, 2018

I've pushed an effect branch here now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants