Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chapter 5] Add a note on Unit #460

Merged
merged 1 commit into from
Nov 11, 2023
Merged

[Chapter 5] Add a note on Unit #460

merged 1 commit into from
Nov 11, 2023

Conversation

Zelenya
Copy link

@Zelenya Zelenya commented Nov 4, 2023

Addressed #340

@Zelenya Zelenya changed the title [Chapter 5] Add a not on Unit [Chapter 5] Add a note on Unit Nov 4, 2023
milesfrain
milesfrain approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@milesfrain milesfrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

For reference, this was one of my Unit clarification attempts from a while back:
purescript/purescript-prelude#219

@Zelenya
Copy link
Author

Zelenya commented Nov 11, 2023

I hesitate to compare to void because of m Unit vs. Unit

@Zelenya Zelenya merged commit 874eefe into master Nov 11, 2023
2 checks passed
@Zelenya Zelenya deleted the chapter5/unit branch November 11, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesfrain milesfrain milesfrain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zelenya @milesfrain