Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NLU-3534] Fix for case like 'March one 2020' #73

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

andrew-gradinari
Copy link
Collaborator

@andrew-gradinari andrew-gradinari commented Apr 26, 2023

Recognizers fails to pick up the year for dates in the format of "Month(text) Day(text) Year(digit)":

  • April first 20212023-04-01 / 2024-04-01
  • March one 20202023-03-01 / 2024-03-01

There is also a problem with the resolved values - PastResolution is in the future when it should be in the past relative to ReferenceDateTime:

{
  "Input": "Oct twenty three",
  "Context": {
    "ReferenceDateTime": "2023-04-25T00:00:00"
  },
  "Results": [
    {
      "Text": "Oct twenty three",
      "Type": "date",
      "Value": {
        "Timex": "XXXX-10-23",
        "PastResolution": {
          "date": "2024-10-23"
        },
        "FutureResolution": {
          "date": "2023-10-23"
        }
      },
      "Start": 0,
      "Length": 16
    }
  ]
}

@andrew-gradinari
Copy link
Collaborator Author

@andrew-gradinari
Copy link
Collaborator Author

MS PR: microsoft#3099

@andrew-gradinari andrew-gradinari merged commit 51dfd28 into develop May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants