Bugfix/NLU-3519: German: invalid date fix #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-gradinari
force-pushed
the
bugfix/NLU-3519
branch
from
dbf952f
to
8fe5edf
Compare
andrew-gradinari
requested review from
sanhal,
kevinwalshgen,
samhickey25,
Conor-Keaney and
KanchanKumar12
andrew-gradinari
force-pushed
the
bugfix/NLU-3519
branch
from
8fe5edf
to
3bd9117
Compare
|
MS PR: microsoft#3094 |
KanchanKumar12
approved these changes
Apr 18, 2023
Conor-Keaney
approved these changes
Apr 18, 2023
samhickey25
approved these changes
Apr 18, 2023
andrew-gradinari
force-pushed
the
bugfix/NLU-3519
branch
from
3bd9117
to
45f3afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and testing for invalid dates for German.
Details
Invalid dates like "32.04.2023" are being resolved incorrectly as "2023-04-02":
{ "text": "2.04.", "type_name": "datetimeV2.date", "start": 1, "end": 5, "resolution": { "values": [ { "timex": "XXXX-04-02", "type": "date", "value": "2023-04-02" }, { "timex": "XXXX-04-02", "type": "date", "value": "2024-04-02" } ] } }This fix changes the resolution of "32.04.2023" to:
{ "text": "04.2023", "type_name": "datetimeV2.daterange", "start": 3, "end": 9, "resolution": { "values": [ { "timex": "2023-04", "type": "daterange", "start": "2023-04-01", "end": "2023-05-01" } ] } }Probably there should be no match but that is the way MS-Recognizers extracts dates. More info: microsoft#209 and microsoft#1846 (comment)
Created another ticket for this issue - https://inindca.atlassian.net/browse/NLU-3545