contacts.find with null or empty array args should fire error callbac…

…k. tests + fix
purdrew · Feb 15, 2012 · bf37bd3 · bf37bd3
1 parent a3da79c
commit bf37bd3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/plugin/contacts.js b/lib/plugin/contacts.js
@@ -19,7 +19,7 @@ var contacts = {
         if (!successCB) {
             throw new TypeError("You must specify a success callback for the find command.");
         }
-        if (!fields) {
+        if (!fields || (fields instanceof Array && fields.length === 0)) {
             if (typeof errorCB === "function") {
                 errorCB(new ContactError(ContactError.INVALID_ARGUMENT_ERROR));
             }

diff --git a/test/test.contacts.js b/test/test.contacts.js
@@ -33,12 +33,18 @@ describe("contacts", function () {
             expect(contacts.find).toThrow("You must specify a success callback for the find command.");
         });
 
-        it("doesn't call exec with no fields", function () {
+        it("doesn't call exec with null fields", function () {
             exec.reset();
             contacts.find(null, jasmine.createSpy());
             expect(exec).not.toHaveBeenCalled();
         });
 
+        it("doesn't call exec with empty fields", function () {
+            exec.reset();
+            contacts.find([], jasmine.createSpy());
+            expect(exec).not.toHaveBeenCalled();
+        });
+
         it("calls the error callback when no fields provied", function () {
             var success = jasmine.createSpy(),
                 error = jasmine.createSpy();