Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability #235

Nanboom233 · 2025-01-29T15:59:58Z

#234

… clarity and maintainability.

Fix static config loading and update package requirements.

Refactor module structure and validate chapter range dynamically.

Add validation for submission number range in explore_hard_task logic.

… and logic for modular structure.

Nanboom233 · 2025-01-29T17:36:56Z

注意：代码未完成且未经过完整测试

note: 1. [Global] and [JP] server - normal_task_challenge2-finished - normal_task_challenge2-unfinished template do not exist since no such task open

pur1fying · 2025-01-30T13:35:16Z

三服检查challenge已适配并测试

pur1fying · 2025-01-30T16:16:56Z

后续打算:

简化普通推图配置，将普通图推图的 "强制打每一关" 和 "是否强制打到sss" 删除，用户只需指定推图区域，BAAS就可以自动检测区域内每个任务是否需要打

Nanboom233 · 2025-01-30T16:19:58Z

感觉强制重推可以留但确实好像没什么用，确定是要删是吗

…

________________________________ From: pur1fying ***@***.***> Sent: Friday, January 31, 2025 12:17:20 AM To: pur1fying/blue_archive_auto_script ***@***.***> Cc: NanBoom ***@***.***>; Author ***@***.***> Subject: Re: [pur1fying/blue_archive_auto_script] Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability (PR #235) 后续打算: 1. 简化普通推图配置，将普通图推图的 "强制打每一关" 和 "是否强制打到sss" 删除，用户只需指定推图区域，BAAS就可以自动检测区域内每个任务是否需要打 ― Reply to this email directly, view it on GitHub<#235 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKNXZY3YAYTOVSCMCDPAVIL2NJGBBAVCNFSM6AAAAABWDGOIPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUHE2DIMZUGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

pur1fying · 2025-01-30T16:22:12Z

是的，打一次没sss那很可能是配置不够了，后续没必要再打了

Nanboom233

hard task 的推图数据丢了 😂

Nanboom233 · 2025-01-29T17:41:32Z

core/ocr/ocr.py

@@ -85,8 +85,22 @@ def get_region_num(self, img, region, category=int, ratio=1.0):

        if temp == '':
            return "UNKNOWN"
+        # 不提倡返回值类型不统一


此处返回值不统一，这意味着调用这里必须加特判，否则很容易炸锅

Nanboom233 · 2025-01-30T16:50:51Z

hard task 的推图数据是不是忘记添加了？ @pur1fying

pur1fying · 2025-01-30T16:55:55Z

抱歉，没检查就提交了

Nanboom233 · 2025-01-31T06:38:26Z

后续打算:

简化普通推图配置，将普通图推图的 "强制打每一关" 和 "是否强制打到sss" 删除，用户只需指定推图区域，BAAS就可以自动检测区域内每个任务是否需要打

我将同步删除hard task配置，自动检测是否需要补task或者present

pur1fying · 2025-01-31T06:41:59Z

好的，我想最终效果应该是用户指只需要输入15, 16-1这样的关卡，不需要再指定挑战/sss/礼物

Nanboom233 · 2025-01-31T08:54:43Z

@pur1fying

main_story.auto_fight(self) if self.config['manual_boss']: self.click(1235, 41) hard_task.to_hard_event(self) normal_task.to_normal_event(self, True)

求问在explore_normal_task 中执行to_hard_event的作用是什么？

pur1fying · 2025-01-31T09:40:01Z

@pur1fying

main_story.auto_fight(self) if self.config['manual_boss']: self.click(1235, 41) hard_task.to_hard_event(self) normal_task.to_normal_event(self, True)

求问在explore_normal_task 中执行to_hard_event的作用是什么？

打完一关后会解锁下一关，关卡列表会向下滑动，切到困难关这个动画就肯定结束了

…ng for better clarity. BREAKING CHANGE: 基本完全重构

…etails.

…eadability and efficiency. 2.refactor tasklist to avoid thread conflicts

Nanboom233 · 2025-01-31T15:24:43Z

后续计划：

1. 优化选队逻辑：依据爆发 -> 神秘 -> (振动) -> 贯穿 -> 的循环链表优先级策略取代原有的选队优先级
2. 选队不再分1/2队，只按属性计算
3. 增加从预设中选取队伍的功能优化推图配队方案 #223
4. 在GUI中的用户设置适配更改，增加预设队伍属性的设置
5. 增加normal推关对于-A关卡的支持（相当于sub任务）
6. 最后进行完整的三服测试，修复出现的bug

Add early return for empty tasklist in normal and hard task methods.

…uto_script into pr/235

Nanboom233 added 6 commits January 29, 2025 19:45

refactor(explore-hard-task): Refactor explore hard task functions for…

ffee948

… clarity and maintainability.

fix(main):

b6b5006

Fix static config loading and update package requirements.

fix(explore-hard-task):

15ccb6f

Refactor module structure and validate chapter range dynamically.

fix(explore-hard-task):

b8ba9f2

Add validation for submission number range in explore_hard_task logic.

style(explore-hard-task): Enhance log messages and correct indentation

7b16f08

refactor(explore-normal-task): Refactor explore_normal_task imports…

f7a78ca

… and logic for modular structure.

Nanboom233 changed the title ~~Refactor explore_hard_task.py for clarity and maintainability~~ Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability Jan 29, 2025

update : verify challenge state

1742373

note: 1. [Global] and [JP] server - normal_task_challenge2-finished - normal_task_challenge2-unfinished template do not exist since no such task open

change all explore_task_data file from python module to json

13cb38d

Nanboom233 commented Jan 30, 2025

View reviewed changes

fix : missing hard task data

80798bc

Nanboom233 added 3 commits January 31, 2025 22:07

refactor(explore-hard-task): Refactor task validation and data handli…

4ed01ec

…ng for better clarity. BREAKING CHANGE: 基本完全重构

docs(picture): Update doc to clarify feature detection and argument d…

c501e6f

…etails.

refactor(explore-task): 1.Refactor task handling methods for better r…

8b8f9a5

…eadability and efficiency. 2.refactor tasklist to avoid thread conflicts

Nanboom233 and others added 3 commits January 31, 2025 23:43

chore(explore-task): Early return if empty tasklist

aa7adfd

Add early return for empty tasklist in normal and hard task methods.

bug fix and delete useless ui and config

366b956

Merge branch 'master' of https://github.com/Nanboom233/blue_archive_a…

8fb3e75

…uto_script into pr/235

pur1fying merged commit 57aa240 into pur1fying:master Jan 31, 2025

Nanboom233 mentioned this pull request Jan 31, 2025

[Proposal] Refactor for clarity and maintainability #234

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability #235

Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability #235

Nanboom233 commented Jan 29, 2025

Nanboom233 commented Jan 29, 2025

pur1fying commented Jan 30, 2025

pur1fying commented Jan 30, 2025

Nanboom233 commented Jan 30, 2025 via email

pur1fying commented Jan 30, 2025

Nanboom233 left a comment

Nanboom233 Jan 29, 2025

Nanboom233 commented Jan 30, 2025 •

edited

Loading

pur1fying commented Jan 30, 2025

Nanboom233 commented Jan 31, 2025

pur1fying commented Jan 31, 2025

Nanboom233 commented Jan 31, 2025 •

edited

Loading

pur1fying commented Jan 31, 2025

Nanboom233 commented Jan 31, 2025 •

edited

Loading

Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability #235

Refactor explore_hard_task.py and explore_normal_task.py for clarity and maintainability #235

Conversation

Nanboom233 commented Jan 29, 2025

Nanboom233 commented Jan 29, 2025

pur1fying commented Jan 30, 2025

pur1fying commented Jan 30, 2025

Nanboom233 commented Jan 30, 2025 via email

pur1fying commented Jan 30, 2025

Nanboom233 left a comment

Choose a reason for hiding this comment

Nanboom233 Jan 29, 2025

Choose a reason for hiding this comment

Nanboom233 commented Jan 30, 2025 • edited Loading

pur1fying commented Jan 30, 2025

Nanboom233 commented Jan 31, 2025

pur1fying commented Jan 31, 2025

Nanboom233 commented Jan 31, 2025 • edited Loading

pur1fying commented Jan 31, 2025

Nanboom233 commented Jan 31, 2025 • edited Loading

Nanboom233 commented Jan 30, 2025 •

edited

Loading

Nanboom233 commented Jan 31, 2025 •

edited

Loading

Nanboom233 commented Jan 31, 2025 •

edited

Loading