Mergeup #2886
Merged
Mergeup #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…64 build for puppetserver in 7.x
…bian-12-x-86-64-builds-and-testing-for-puppetserver-in-7-x (SERVER-3390): Updated ezbake build version to support debian-12-x86_64 build for puppetserver in 7.x
We have triggered a nasty performance regression in the JVM[1] with some of our Regex usage in the MetricsPuppetProfiler (particularly the PuppetDB Patterns). Regardless of the performance regression, our Regex usage is unnecessary and unneedlessly expensive (I believe it was taking up ~3% of samples from JFR in an unrelated support escalation). This patch moves from iterating over all metrics and doing regex matches to pull out only those that match the desired pattern when metrics are requested, to caching references to desired metrics in maps as they are recorded. The keys of these maps should be the same as the match group from the previous patterns.
Based on discussion with Austin Blatt these additional metrics could be helpful in diagnosing issues with PuppetDB. > The reports.process, catalog.save and facts.save metrics would likely be > useful as they are the highest level metrics closest to "how long did the > puppetdb terminus take?". > > puppetdb.payload.format would be good to include as well in case our json > conversion is slow. We do have to do some string manipulation there, so it > isn't just Ruby's to_json function. > > I'm less familiar with the terminus's use for querying, but I imagine > puppetdb.query, puppetdb.facts.find, and puppetdb.facts.search would be > good to include assuming those terminus functions are used somewhere.
clj-kondo version 2024.03.05 fixed a bug which suppressed the :java-static-field-call warning in some cases. Linting is now erroring in CI and this patch should resolve that issue.
(PE-38408) Remove expensive Regexes from puppet profiler Java impl
…pts-acceptance (maint) Do not install docs and pin to 3.x when installing r10k in acceptance
* upstream/7.x: (maint) Do not install docs and pin to 3.x when installing r10k in acceptance (maint) update submodule versions and agent pin (maint) Address new clj-kondo issues (PE-38408) Add additional PuppetDB metrics (PE-38408) Remove expensive Regexes from puppet profiler Java impl (SERVER-3390): Updated ezbake build version to support debian-12-x86_64 build for puppetserver in 7.x (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin (maint) update submodule versions and agent pin
justinstoller
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.