(PE-37348) connect bulk signing behavior to endpoint #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http endpoint for bulk signing expects to have three possible outcomes for a set of csrs: * they can be signed * they can be not-found * they can fail when signing This updates the result of the `sign-multiple-certificate-signing-requests!` function to make the result have those three fields, instead of the two provided before. Tests were updated to match the new expectations.
This connects the `/v1/sign` ca endpoint to the routine that does the work of signing the identified csrs. It adds a test to demonstrate the behaviors of the endpoint when presented with csrs in different states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit comments.