(PE-36269) ensure CRLs are regenerated when nearing expiration #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alters the analytics service to explicitly stop the jobs it is running when shutting down. It also adds some simple logging to the startup / shutdown process. Additionally, an unused dependency in the `master_service` was removed.
jonathannewman
force-pushed
the
PE-36269/main/regen-crls
branch
from
a6fd181
to
28b2114
Compare
jonathannewman
changed the title
jonathannewman
force-pushed
the
PE-36269/main/regen-crls
branch
from
28b2114
to
c4a6122
Compare
This adds a new behavior where once a day, puppetserver will check to see if the crls for both the main crl, and if enabled the infra-crl are nearing expiration. If one is, the list of expired serial numbers is collected from the inventory file, and used to prune the CRL list. The CRL is then regenerated with the (potentially) smaller set of serials. If the CRLs are not nearing expiration, nothing is done. Tests are added to demonstrate the CRL behaviors added.
jonathannewman
force-pushed
the
PE-36269/main/regen-crls
branch
from
c4a6122
to
8927014
Compare
justinstoller
approved these changes
Nov 15, 2023
|
I guess this is in 2023.6.0, but it's not in the release notes. Would be good to get it added. Thanks! https://www.puppet.com/docs/pe/2023.6/release_notes_pe#release_notes_pe_x-6 |
|
@kenyon Thanks! We will get it added to the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit:
This alters the analytics service to explicitly stop the jobs it is running when shutting down. It also adds some simple logging to the startup / shutdown process.
Additionally, an unused dependency in the
master_servicewas removed.In the second commit:
This adds a new behavior where once a day, puppetserver will check to
see if the crls for both the main crl, and if enabled the infra-crl
are nearing expiration. If one is, the list of expired serial numbers
is collected from the inventory file, and used to prune the CRL list.
The CRL is then regenerated with the (potentially) smaller set of serials.
If the CRLs are not nearing expiration, nothing is done.
Tests are added to demonstrate the CRL behaviors added.
Resolves #2789