(PE-36076) Remove content type from certificate reject #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artlawson
force-pushed
the
pe_36076
branch
4 times, most recently
from
46fef94
to
1a5b302
Compare
steveax
reviewed
Jul 31, 2023
| @@ -350,7 +348,6 @@ | |||
| msg-matcher (re-pattern (str "Path " expected-path " exists but.*"))] | |||
| (is (= 500 (:status response))) | |||
| (is (re-matches msg-matcher (:body response))) | |||
| (is (= "text/plain" (get-in response [:headers "Content-Type"]))) | |||
There was a problem hiding this comment.
This seems odd. The 500 should return some sort of error and a Content-Type along with it. It may be that you'll need to add the content type specifically to the 500 error (which has a body).
artlawson
force-pushed
the
pe_36076
branch
6 times, most recently
from
11c5c53
to
eca725b
Compare
steveax
requested changes
Aug 1, 2023
Previously, when a `DELETE` request was sent to `puppet-ca/v1/certificate_status/<nodename>` a 204 response was sent with a malformed content-type header. This commit removes the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a
DELETErequest was sent topuppet-ca/v1/certificate_status/<nodename>a204response was sent with a malformed content-type header. This commit removes the header.