GitHub Actions workflow: add lint, install, unittest. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldaneliukas
changed the title
ldaneliukas
force-pushed
the
improve_ci
branch
from
52955bd to
95e5c74
Compare
ldaneliukas
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Xtigyro
suggested changes
Nov 27, 2023
Xtigyro
suggested changes
Nov 27, 2023
Xtigyro
approved these changes
Nov 27, 2023
Xtigyro
suggested changes
Nov 27, 2023
Xtigyro
approved these changes
Nov 29, 2023
|
@ldaneliukas Oops, I thought you updated it. My bad. Could you please open a new PR with just that? |
Yep, will do later today. Dealing with some time-sensitive things atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GHA workflow is somewhat lacking as it does not properly test the changes that are being done, which could result in merges with a chart that can't be installed.
Separated the workflow into two stages, one for pull requests and one for releases via
workflow_dispatch. The job that runs on pull requests tests the chart by running lint, installing it to a cluster and running unit tests. This also removes the required inputs fromworkflow_dispatchas they can be automatically determined from the context, which will help when releasing it from forks (won't need to update the values every time).Updating all unittest as part of this as they were already failing, the CI will help with keeping them up to date.
Chart version remains the same, since the Chart templates/functionality were not modified in this PR.