Remove Puppet-debugger customisation #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed and will create an issue when updating to PDK 2.6
mcka1n
reviewed
Jan 17, 2023
| @@ -2,8 +2,6 @@ | |||
| Gemfile: | |||
| required: | |||
| ':development': | |||
| - gem: 'puppet-debugger' | |||
There was a problem hiding this comment.
@davidsandilands I wonder if this is still a requirement for PDK versions <= 2.5.0
There was a problem hiding this comment.
Hmm this gets messy.... we haven't updated since "pdk-version": "2.2.0", and 2.5.0 is also broken with the
pdk (FATAL):
[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice with different version requirements.
You specified: puppet-debugger (~> 1.0) and puppet-debugger (>= 0.18.0). Bundler cannot continue.
# from /root/puppetlabs-peadm/Gemfile:37
# -------------------------------------------
# gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
> gem "puppet-debugger", '>= 0.18.0', require: false
# gem "bolt", '>= 3.10.0', require: false
# -------------------------------------------
pdk (FATAL): Unable to resolve Gemfile dependencies.
but if I used this fix with PDK 2.5 running validate goes horribly wrong when trying to run commands
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application
for all non-root users on this machine.
The dependency rb-readline (= 0.5.5) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mswin32, x86-mingw32, x64-mingw32. To add those platforms to the bundle, run `bundle lock --add-platform x86-mswin32 x86-mingw32 x64-mingw32`.
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
/opt/puppetlabs/pdk/private/ruby/2.7.6/bin/ruby -I /opt/puppetlabs/pdk/private/ruby/2.7.6/lib/ruby/site_ruby/2.7.0 -r
./siteconf20230117-626-4tc8lc.rb extconf.rb
checking for -lstdc++... no
creating Makefile
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
make "DESTDIR=" clean
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
make "DESTDIR="
compiling unf.cc
make: g++: Command not found
make: *** [Makefile:213: unf.o] Error 127
make failed, exit code 2
Gem files will remain installed in /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2 for inspection.
Results logged to /root/.pdk/cache/ruby/2.7.0/extensions/x86_64-linux/2.7.0/unf_ext-0.0.8.2/gem_make.out
An error occurred while installing unf_ext (0.0.8.2), and Bundler cannot continue.
Make sure that `gem install unf_ext -v '0.0.8.2' --source 'https://rubygems.org/'` succeeds before bundling.
In Gemfile:
puppet_litmus was resolved to 0.34.4, which depends on
rspec_honeycomb_formatter was resolved to 0.2.1, which depends on
honeycomb-beeline was resolved to 2.11.0, which depends on
libhoney was resolved to 2.2.0, which depends on
http was resolved to 5.1.1, which depends on
http-cookie was resolved to 1.0.5, which depends on
domain_name was resolved to 0.5.20190701, which depends on
unf was resolved to 0.1.4, which depends on
unf_ext
pdk (FATAL): Unable to install missing Gemfile dependencies.
|
So do you have a suggestion how to move forward from here?
Dimitri Tischenko
Solutions Architect | EMEA
***@***.******@***.***> | @timidri
slack.puppet.com<http://slack.puppet.com/> | #puppet
Patterns and tactics<https://puppet.com/docs/patterns-and-tactics/latest/patterns-and-tactics.html> by the Puppet Solutions Architects team
________________________________
From: David Sandilands ***@***.***>
Sent: Tuesday, 17 January 2023 14:55
To: puppetlabs/puppetlabs-peadm ***@***.***>
Cc: Dimitri Tischenko ***@***.***>; Review requested ***@***.***>
Subject: Re: [puppetlabs/puppetlabs-peadm] Remove Puppet-debugger customisation (PR #313)
@davidsandilands commented on this pull request.
________________________________
In .sync.yml<#313 (comment)>:
@@ -2,8 +2,6 @@
Gemfile:
required:
':development':
- - gem: 'puppet-debugger'
Hmm this gets messy.... we haven't updated since "pdk-version": "2.2.0", and 2.5.0 is also broken with the
pdk (FATAL):
[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice with different version requirements.
You specified: puppet-debugger (~> 1.0) and puppet-debugger (>= 0.18.0). Bundler cannot continue.
# from /root/puppetlabs-peadm/Gemfile:37
# -------------------------------------------
# gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "puppet-debugger", '>= 0.18.0', require: false
# gem "bolt", '>= 3.10.0', require: false
# -------------------------------------------
pdk (FATAL): Unable to resolve Gemfile dependencies.
but if I used this fix with PDK 2.5 running validate goes horribly wrong when trying to run commands
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application
for all non-root users on this machine.
The dependency rb-readline (= 0.5.5) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mswin32, x86-mingw32, x64-mingw32. To add those platforms to the bundle, run `bundle lock --add-platform x86-mswin32 x86-mingw32 x64-mingw32`.
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
/opt/puppetlabs/pdk/private/ruby/2.7.6/bin/ruby -I /opt/puppetlabs/pdk/private/ruby/2.7.6/lib/ruby/site_ruby/2.7.0 -r
./siteconf20230117-626-4tc8lc.rb extconf.rb
checking for -lstdc++... no
creating Makefile
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
make "DESTDIR=" clean
current directory: /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2/ext/unf_ext
make "DESTDIR="
compiling unf.cc
make: g++: Command not found
make: *** [Makefile:213: unf.o] Error 127
make failed, exit code 2
Gem files will remain installed in /root/.pdk/cache/ruby/2.7.0/gems/unf_ext-0.0.8.2 for inspection.
Results logged to /root/.pdk/cache/ruby/2.7.0/extensions/x86_64-linux/2.7.0/unf_ext-0.0.8.2/gem_make.out
An error occurred while installing unf_ext (0.0.8.2), and Bundler cannot continue.
Make sure that `gem install unf_ext -v '0.0.8.2' --source 'https://rubygems.org/'` succeeds before bundling.
In Gemfile:
puppet_litmus was resolved to 0.34.4, which depends on
rspec_honeycomb_formatter was resolved to 0.2.1, which depends on
honeycomb-beeline was resolved to 2.11.0, which depends on
libhoney was resolved to 2.2.0, which depends on
http was resolved to 5.1.1, which depends on
http-cookie was resolved to 1.0.5, which depends on
domain_name was resolved to 0.5.20190701, which depends on
unf was resolved to 0.1.4, which depends on
unf_ext
pdk (FATAL): Unable to install missing Gemfile dependencies.
—
Reply to this email directly, view it on GitHub<#313 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAMDM7ON3NXLJ7PQL2X4BTTWS2QFBANCNFSM6AAAAAAT53J4WA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
This e-mail may contain information that is privileged or confidential. If you are not the intended recipient, please delete the e-mail and any attachments and notify us immediately.
|
|
@timidri not yet I thought it was something I could quickly fix but I will need to come back to this to review it in full |
|
This has been covered in #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed as the version has increased since it was added and will create an issue when updating to PDK 2.6 which enforces Debugger to 1 and above