-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(REPLATS-487) Add plan to install helm charts #12
Conversation
737b340
to
ccfe34d
Compare
Generic plan for installing helm charts that handles adding a local helm repository first, if required, and waiting for the deployments and statefulsets to rollout if a selector is specified.
ccfe34d
to
9204fc1
Compare
* [`targets`](#targets) | ||
* [`chart_name`](#chart_name) | ||
* [`release`](#release) | ||
* [`repository_uri`](#repository_uri) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking this seems to take you to the repository_uri
under "helm_add_repository" instead of "pam_tools::install_chart".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks like a puppet-strings bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should clarify; REFERENCE.md is generated by rake strings:generate:reference which is a puppet-strings rake helper. If I manually edit for these issues, it will come into conflict or be reset the next time REFERENCE gets auto generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like puppet-strings is using github issues; I'll open a bug there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* [`release`](#release) | ||
* [`repository_uri`](#repository_uri) | ||
* [`values_yaml`](#values_yaml) | ||
* [`namespace`](#namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, this link seems to go to the namespace
under "helm_install_chart".
* [`values_yaml`](#values_yaml) | ||
* [`namespace`](#namespace) | ||
* [`part_of`](#part_of) | ||
* [`timeout`](#timeout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one goes to "get_ingress_ip"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that stands out to me are the puppet strings related link oddities.
These weren't displaying properly as code in the REFERENCE.md.
af310da
to
da8d7ac
Compare
Generic plan for installing helm charts that handles adding a local helm
repository first, if required, and waiting for the deployments and
statefulsets to rollout if a selector is specified.