Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calico-tigera installation problems #639

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

jorhett
Copy link
Contributor

@jorhett jorhett commented Jun 8, 2023

Update network preinstall and provider target URLs. Current ones return

Notice: /Stage[main]/Kubernetes::Kube_addons/Exec[Install cni network (preinstall)]/returns: error: unable to read URL "https://docs.projectcalico.org/manifests/tigera-operator.yaml", server reported 404 Not Found, status code=404
Error: '["kubectl", "apply", "-f", "https://docs.projectcalico.org/manifests/tigera-operator.yaml"]' returned 1 instead of one of [0]
Error: /Stage[main]/Kubernetes::Kube_addons/Exec[Install cni network (preinstall)]/returns: change from 'notrun' to ['0'] failed: '["kubectl", "apply", "-f", "https://docs.projectcalico.org/manifests/tigera-operator.yaml"]' returned 1 instead of one of [0]
Warning: Private key for 'test.foo.bar' does not exist
Warning: Client certificate for 'test.foo.bar' does not exist
Error: /Stage[main]/Kubernetes::Kube_addons/File[/etc/kubernetes/calico-installation.yaml]: Could not evaluate: Could not retrieve information from environment production source(s) https://docs.projectcalico.org/manifests/custom-resources.yaml

Found problem reported in projectcalico/calico#7300
Documentation now shows the raw URLs for the explicit version being used https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico

Use kubectl create to avoid metadata length limitations

Sourced from upstream projectcalico/calico#6811 and docs at https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico

@jorhett jorhett requested a review from a team as a code owner June 8, 2023 08:00
@jorhett jorhett force-pushed the jrhett/fix-tiagra-operator-install branch from c2633ef to 2f6011e Compare June 8, 2023 08:19
@jorhett
Copy link
Contributor Author

jorhett commented Jun 9, 2023

I overlooked that this overlaps with #617, should probably be combined.

@jordanbreen28
Copy link
Contributor

@jorhett some of this work was merged in with #625, are you able to refer to this, rebase and check if anything extra from your implementation is needed?
Thanks for your work on this! 🚀

@jordanbreen28
Copy link
Contributor

did you get the chance to review the comment above @jorhett ?

@jorhett jorhett force-pushed the jrhett/fix-tiagra-operator-install branch from 2f6011e to 90eb360 Compare November 19, 2023 20:25
@jorhett
Copy link
Contributor Author

jorhett commented Nov 19, 2023

I've rebased from main as of today. All of the problems I originally reported remain unfixed so this PR remains valid.

@deric
Copy link
Collaborator

deric commented Nov 20, 2023

@jorhett Please, update the specs accordingly, e.g. apply -> create

Update network preinstall and provider target URLs
Use kubectl create to avoid metadata length limitations
@jorhett jorhett force-pushed the jrhett/fix-tiagra-operator-install branch from 21650da to 7bf9f75 Compare December 3, 2023 07:48
@jorhett jorhett force-pushed the jrhett/fix-tiagra-operator-install branch from 7bf9f75 to b3c184a Compare December 3, 2023 08:02
@jorhett
Copy link
Contributor Author

jorhett commented Dec 9, 2023

@deric should I assume you'll merge this when ready for the next release?

@deric deric merged commit 7bebd70 into puppetlabs:main Dec 9, 2023
7 checks passed
@jorhett jorhett mentioned this pull request Jan 14, 2024
@jorhett jorhett deleted the jrhett/fix-tiagra-operator-install branch January 14, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants