-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calico-tigera installation problems #639
Merged
deric
merged 2 commits into
puppetlabs:main
from
jorhett:jrhett/fix-tiagra-operator-install
Dec 9, 2023
Merged
Fix calico-tigera installation problems #639
deric
merged 2 commits into
puppetlabs:main
from
jorhett:jrhett/fix-tiagra-operator-install
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorhett
force-pushed
the
jrhett/fix-tiagra-operator-install
branch
from
June 8, 2023 08:19
c2633ef
to
2f6011e
Compare
I overlooked that this overlaps with #617, should probably be combined. |
did you get the chance to review the comment above @jorhett ? |
jorhett
force-pushed
the
jrhett/fix-tiagra-operator-install
branch
from
November 19, 2023 20:25
2f6011e
to
90eb360
Compare
I've rebased from main as of today. All of the problems I originally reported remain unfixed so this PR remains valid. |
@jorhett Please, update the specs accordingly, e.g. apply -> create |
Update network preinstall and provider target URLs Use kubectl create to avoid metadata length limitations
jorhett
force-pushed
the
jrhett/fix-tiagra-operator-install
branch
from
December 3, 2023 07:48
21650da
to
7bf9f75
Compare
jorhett
force-pushed
the
jrhett/fix-tiagra-operator-install
branch
from
December 3, 2023 08:02
7bf9f75
to
b3c184a
Compare
deric
approved these changes
Dec 4, 2023
@deric should I assume you'll merge this when ready for the next release? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update network preinstall and provider target URLs. Current ones return
Found problem reported in projectcalico/calico#7300
Documentation now shows the raw URLs for the explicit version being used https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico
Use
kubectl create
to avoid metadata length limitationsSourced from upstream projectcalico/calico#6811 and docs at https://docs.tigera.io/calico/3.26/getting-started/kubernetes/quickstart#install-calico