Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zfs support when using containerd config and removed udpIdleTim… #619

Closed
wants to merge 1 commit into from

Conversation

ashish1099
Copy link

…eout since its deprecated

@ashish1099 ashish1099 requested a review from a team as a code owner March 21, 2023 11:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ashish Jaiswal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

kubernetes::packages is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Jun 27, 2023

hey @ashish1099, can you add a better description to the PR and address the merge conflicts?
I'd opt to break out the two changes into separate PRs also, to allow for an accurate changelog entry.

@jordanbreen28
Copy link
Contributor

Closing due to inactivity, please re-open when ready to pick this back up @ashish1099

@ashish1099
Copy link
Author

@jordanbreen28 have raised the PR here now #667

I completely forgot about this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants