[Backport 7.x] Drop remnants of rake package:apple support #9374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package:apple` rake task was used to install a version of CFPropertyList to speed up plist reads/writes. However, that task has been broken since at least commit d988fe7 when the file_mapping.yaml file was deleted: bundle exec rake package:apple rake aborted! Could not load Apple file mappings from 'ext/osx/file_mapping.yaml' Since the `package:apple` rake task hasn't worked since 2021, delete the cfproperty rake task and the "pre_tasks" entry that registers the cfpropertylist task with the packaging gem.
joshcooper
force-pushed
the
backport_package_apple
branch
from
c46fe9c to
f35fe98
Compare
mhashizume
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package:applerake task was used to install a version of CFPropertyList to speed up plist reads/writes. However, that task has been broken since at least commit d988fe7 when the file_mapping.yamlfile was deleted:
Since the
package:applerake task hasn't worked since 2021, delete the cfproperty rake task and the "pre_tasks" entry that registers the cfpropertylist task with the packaging gem.Backport: #9367