Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-4787) Warnings when running embedded ruby #2268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chutzimir
Copy link

Getting warnings when running the wrapped binaries when bundler has
exported some environment variables. The fix is to clean out the
environment before running the ruby process which strips the
LD_LIBRARY_PATH.

@chutzimir chutzimir requested a review from a team as a code owner July 21, 2022 00:27
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2022

CLA assistant check
All committers have signed the CLA.

@chutzimir
Copy link
Author

I cannot make a Jira ticket as Jira is not letting me make an account (it says my email is already in use), and if I request username recovery, I don't get any email. So I'm a bit stuck on how to report this issue.

@joshcooper
Copy link
Contributor

Thanks for submitting this PR @chutzimir. Let me check with some folks to see about the JIRA issue.

@chutzimir
Copy link
Author

chutzimir commented Aug 29, 2022

To clarify how to reproduce the issue, I have a ruby script that does some jobs. I run that script using bundler. From the script, I fork out a call to the rt cli. And that one throws a bunch of warnings as it is trying to find stuff in the location of my parent bundler environment.

@chutzimir chutzimir changed the title Warnings when running embedded ruby (PA-4787) Warnings when running embedded ruby Oct 28, 2022
Getting warnings when running the wrapped binaries when bundler has
exported some environment variables. The fix is to clean out the
environment before running the ruby process which strips the
`LD_LIBRARY_PATH`.
@chutzimir
Copy link
Author

Thanks for submitting this PR @chutzimir. Let me check with some folks to see about the JIRA issue.

I was able to get in Jira and made a ticket. Also updated the commit to have the ticket number and rebased the branch on the latest main.

@joshcooper
Copy link
Contributor

What is the rt cli? Can you provide steps to reproduce?

@chutzimir
Copy link
Author

What is the rt cli? Can you provide steps to reproduce?

The full details are in https://puppet.atlassian.net/browse/PA-4787

The rt may have been a mistake on my end. I reproduced this with shelling a call to facter. Though I have not been working in this environment for a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants