Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2121) Update tests to account for pdk validate changes #1409

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Oct 24, 2024

Updating the tests to account for puppet-lint configuration changes to the pdk-templates brought in here: puppetlabs/pdk-templates#600

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Oct 24, 2024
@david22swan david22swan force-pushed the CAT-2121 branch 2 times, most recently from ab81d65 to ddeade9 Compare October 25, 2024 09:41
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (66644df) to head (6b2290c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1409   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         127      127           
  Lines        5320     5320           
=======================================
  Hits         4708     4708           
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan force-pushed the CAT-2121 branch 4 times, most recently from 5db651d to 7d42082 Compare October 25, 2024 11:26
A fix for the issue requiring the pin has been released
@david22swan david22swan marked this pull request as ready for review October 28, 2024 14:13
@david22swan david22swan requested a review from a team as a code owner October 28, 2024 14:13
@david22swan david22swan changed the title (CAT-2121) Update tests to account for validate changes (CAT-2121) Update tests to account for pdk validate changes Oct 28, 2024
@david22swan
Copy link
Member Author

Ruby 3 Windows failures are expected

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 2331637 into main Oct 28, 2024
11 of 12 checks passed
@LukasAud LukasAud deleted the CAT-2121 branch October 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants