Disable the windows 2019 ruby 3.2 acceptance test #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 127 127
Lines 5320 5320
=======================================
Hits 4708 4708
Misses 612 612 ☔ View full report in Codecov by Sentry. |
gavindidrichsen
force-pushed
the
maint_disable_win_ruby32_accep_test
branch
from
4ca3489
to
ef6caa9
Compare
…test. Our current daily nightly summary includes a failure on the pdk acceptance test that has been occurring for some months, specifically the windows 2019, ruby 3.2 one. Although we are aware that this error is indeed outstanding and occurs every day, the problem is that it can easily “hide” a valid error that we need to fix. This PR temporarily disables this test until the CAT-2122 ticket addresses and fixes the test. When fixed, then this PR will be rolled back. Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
maint_disable_win_ruby32_accep_test
branch
from
ec6c6c4
to
aa692c8
Compare
|
Testing the nightly produces output without the Windows 2019, ruby 3.2 (as below). Note that all acceptance tests are failing as expected with the new error that needs to be fixed.
|
david22swan
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables the windows 2019, ruby 3.2 acceptance test in the nightly.yml. The main reason for this is that it can potentially hide actual failures as the nightly is always red. Therefore, I've created an internal ticket CAT-2122 to fix the issue and then rollback this PR.
For example, 3 days ago our nightly.yml looked like this, which was what we'd come to expect over the last lot of weeks:
However, 2 days ago nightly revealed further errors (and hidden)