Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2007) Update http setting cert to setting ca_file #1398

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Sep 23, 2024

Summary

Update code based on changes suggested here: #1396 (comment)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan requested a review from a team as a code owner September 23, 2024 16:28
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (2cf7c7e) to head (97a521a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         127      127           
  Lines        5329     5329           
=======================================
  Hits         4716     4716           
  Misses        613      613           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit f8a1a61 into main Sep 24, 2024
10 of 11 checks passed
@LukasAud LukasAud deleted the CAT-2007 branch September 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants