Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CAT-1723) Adjusting expected Puppet/Ruby versions #1317

Merged
merged 1 commit into from
Feb 12, 2024
Merged

(CAT-1723) Adjusting expected Puppet/Ruby versions #1317

merged 1 commit into from
Feb 12, 2024

Conversation

david22swan
Copy link
Member

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Feb 12, 2024
@david22swan david22swan requested a review from a team as a code owner February 12, 2024 10:07
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d5ede3) 88.50% compared to head (6a319e8) 88.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1317   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         133      133           
  Lines        5664     5664           
=======================================
  Hits         5013     5013           
  Misses        651      651

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LukasAud
LukasAud approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit ff3fac4 into main Feb 12, 2024
12 checks passed
@LukasAud LukasAud deleted the CAT-1723/main/update_puppet_versions branch February 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasAud LukasAud LukasAud approved these changes

Assignees
No one assigned
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @LukasAud