Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Update expected error message for test case (RSpec 3.13.0) #1315

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the maintenance Internal maintenance work that shouldn't appear in the changelog label Feb 6, 2024
@jordanbreen28 jordanbreen28 changed the title (maint) - Pin to rspec ~> 3.12.0 (maint) - Update expected error message for test case (RSpec 3.13.0) Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4eb9812) 88.50% compared to head (3654612) 88.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         133      133           
  Lines        5664     5664           
=======================================
  Hits         5013     5013           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 6, 2024 09:38
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner February 6, 2024 09:38
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit fed1c55 into main Feb 6, 2024
10 checks passed
@LukasAud LukasAud deleted the maint-fix_nightlies branch February 6, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants