Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) bump concurrent-ruby version #1302

Closed
wants to merge 2 commits into from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jan 7, 2024

puppet-runtime doesnt support old (buggy) versions anymore
fixes building with pdk-vanagon

puppetlabs/puppet-runtime@f201ef9

puppet-runtime doesnt support old (buggy) versions anymore
fixes building with pdk-vanagon

puppetlabs/puppet-runtime@f201ef9
@h0tw1r3 h0tw1r3 added bug dependency maintenance Internal maintenance work that shouldn't appear in the changelog labels Jan 7, 2024
@h0tw1r3 h0tw1r3 requested a review from a team as a code owner January 7, 2024 00:14
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jan 8, 2024

Not sure how to fix the pdk calling pdk acceptance tests as it's pulling the gem with unsolvable dependencies.

Fixes pipeline https://jenkins-platform.delivery.puppetlabs.net/view/PDK/view/all/job/platform_pdk_pdk-van-build_main/

@LukasAud
Copy link
Contributor

PR has come conflicts that need to be addressed before we can review.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1b3b18) 88.50% compared to head (5a82989) 88.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         133      133           
  Lines        5664     5664           
=======================================
  Hits         5013     5013           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan
Copy link
Member

david22swan commented Jan 29, 2024

Look's like the issues are coming from bolt being pinned to less than concurrent-ruby 1.2.0.
Or at least the bolt version we're bringing in

       Because bolt >= 3.26.2, < 3.27.2 depends on puppet-strings >= 2.3.0, < 4.0
         and bolt >= 1.40.0, < 3.26.2 depends on puppet-strings ~> 2.3,
         bolt >= 1.40.0, < 3.27.2 requires puppet-strings >= 2.3.0, < 4.0.
       And because bolt >= 3.27.1 depends on concurrent-ruby >= 1.0, < 1.2.0
         and every version of pdk depends on concurrent-ruby = 1.2.2,
         if pdk >= 0 and bolt >= 1.40.0 then puppet-strings >= 2.3.0, < 4.0.
       And because puppet_litmus >= 0.34.1 depends on bolt ~> 3.0
         and Gemfile depends on puppet-strings >= 4.0, < 5.A,
         every version of pdk is incompatible with puppet_litmus >= 0.34.1.
       So, because Gemfile depends on puppet_litmus ~> 1.0
         and Gemfile depends on pdk >= 0,
         version solving has failed.

@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented Jan 31, 2024

From other conversations, looks like the goal it to remove the pinning altogether, which is great.

@h0tw1r3 h0tw1r3 closed this Jan 31, 2024
@h0tw1r3 h0tw1r3 deleted the fix-vanagon-build branch February 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependency maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants