-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) bump concurrent-ruby version #1302
Conversation
puppet-runtime doesnt support old (buggy) versions anymore fixes building with pdk-vanagon puppetlabs/puppet-runtime@f201ef9
da8c4c6
to
09022c2
Compare
c34ce67
to
ddd7542
Compare
Not sure how to fix the pdk calling pdk acceptance tests as it's pulling the gem with unsolvable dependencies. Fixes pipeline https://jenkins-platform.delivery.puppetlabs.net/view/PDK/view/all/job/platform_pdk_pdk-van-build_main/ |
PR has come conflicts that need to be addressed before we can review. |
ddd7542
to
5a82989
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 133 133
Lines 5664 5664
=======================================
Hits 5013 5013
Misses 651 651 ☔ View full report in Codecov by Sentry. |
Look's like the issues are coming from bolt being pinned to less than concurrent-ruby 1.2.0.
|
From other conversations, looks like the goal it to remove the pinning altogether, which is great. |
puppet-runtime doesnt support old (buggy) versions anymore
fixes building with pdk-vanagon
puppetlabs/puppet-runtime@f201ef9