(maint) Fix rubocop lint warnings

[gavindidrichsen]

Summary

Nightly CI is failing with the following rubocop warnings:

Run bundle exec rubocop --format github
  bundle exec rubocop --format github
  shell: /usr/bin/bash -e {0}
  env:
    PUPPET_GEM_VERSION: ~> 7.0

Error: Lint/SymbolConversion: Unnecessary symbol conversion; use `:"write_#{format}"` instead.
Error: Style/HashEachMethods: Use `each_value` instead of `each` and remove the unused `_` block argument.
Error: Style/HashEachMethods: Use `each_value` instead of `each` and remove the unused `_tool` block argument.
Error: Style/RedundantParentheses: Don't use parentheses around a logical expression.
Error: Style/HashEachMethods: Use `each_key` instead of `each` and remove the unused `_` block argument.
Error: Style/HashEachMethods: Use `each_key` instead of `each` and remove the unused `_` block argument.
Error: Style/HashEachMethods: Use `each_value` instead of `each` and remove the unused `_source` block argument.
Error: Process completed with exit code 1.

Linting has been fixed and comments added where appropriate.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified.

[jordanbreen28]

LGTM