(CONT-1026) Deprecate release command set #1297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release prep command introduces a dependency on the github-changelog-generator gem which is unmaintained and broken. This ticket exists primarily to remove this command but that introduces an unnecessary level of commands for users. For example ``` pdk release pdk release prep pdk release publish ``` This change deprecates the `release` command set. They will be removed in a future version.
To reduce complexity, this change introduces a new `publish` top-level command. The intention is to replace `pdk release` and `pdk release publish`
pmcmaw
requested changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased duplicate of: #1251
The release prep command introduces a dependency on the
github-changelog-generatorgem which is unmaintained and broken.This PR exists primarily to remove this command but that introduces an unnecessary level of commands for users. For example
Additionally as part of this ticket, we lift up the publish command to the root level so we have the following:
pdk publishDue to the fact that
pdk publishnow has the single responsibility of publishing to the forge,pdk buildhas been changed to perform some pre-build checks, much like the old release command did.By default,
pdk buildwill nowEach step can be skipped by using the respective flag:
--skip-validation--skip-documentation