Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: Add /.vendor/ #594

Merged
merged 1 commit into from
Aug 2, 2024
Merged

.gitignore: Add /.vendor/ #594

merged 1 commit into from
Aug 2, 2024

Conversation

bastelfreak
Copy link
Contributor

In many projects it's common to install gems into .vendor/, not vendor/. people tend to copy and paste commands from their history. I think it makes sense to add it to the .gitignore here as well.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

In many projects it's common to install gems into .vendor/, not vendor/.
people tend to copy and paste commands from their history. I think it
makes sense to add it to the .gitignore here as well.
@bastelfreak bastelfreak requested a review from a team as a code owner July 28, 2024 12:22
@pmcmaw pmcmaw added the feature label Aug 2, 2024
Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pmcmaw pmcmaw merged commit 1e9f9cf into puppetlabs:main Aug 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants