metadata-json-lint: Switch to 4.x #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @bastelfreak - could you address the conflict and we'll get this merged? |
bastelfreak
force-pushed
the
metadata-json-lint
branch
from
9a67a08
to
6ad61da
Compare
|
@jordanbreen28 rebased it. I currently don't have a pdk test environment, so it might be good if someone could test it. |
|
@jordanbreen28 and is there a chance you could test puppetlabs_spec_helper 7? pdk-templates still uses the old 6 release. |
|
@bastelfreak That's great, thanks! I'll take it for a spin before merging, hopefully soon. |
jordanbreen28
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist