(maint) add a little bit of verbosity to deploy_signed_repos_to_s3 #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-gris
force-pushed
the
deploy_to_s3_feedback
branch
2 times, most recently
from
396115e
to
444239e
Compare
e-gris
force-pushed
the
deploy_to_s3_feedback
branch
2 times, most recently
from
a46c7dd
to
4279f92
Compare
e-gris
force-pushed
the
deploy_to_s3_feedback
branch
from
4279f92
to
4825821
Compare
- Make deploy_signed_repos_to_s3 print a message that it is doing the s3sync - Refactor messy code around it - Make rspec work - Update rubocop complaint
e-gris
force-pushed
the
deploy_to_s3_feedback
branch
from
4825821
to
02618f3
Compare
|
Verified on platform-ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add all notable changes to the "Unreleased" section of the CHANGELOG.