Modifies Ubuntu 18.04 task. #436
Conversation
| echo Repo: <%= repo_url %> >> /tmp/razor_complete.log | ||
| echo Node: <%= node_url %> >> /tmp/razor_complete.log | ||
|
|
||
| sed -i '/razor_postinstall/d' /etc/crontab |
There was a problem hiding this comment.
This looks like the only line that has changed so far. Was the other method of stopping the postinstall script not working?
There was a problem hiding this comment.
post install script was never called because ubuntu 18.04 uses systemd instead of init.
adding a line to the crontab works with systemd.
There was a problem hiding this comment.
Ah excellent, that makes sense. Is there a reason this wouldn't work for other Ubuntu versions too? This might be a more portable way to be standard across versions.
There was a problem hiding this comment.
I haven't tested this with other than ubuntu 18.04, this might work for newer version but not sure for older.
| curl -s <%= store_url("ip" => "$node_ip") %> | ||
|
|
||
| # Send final state | ||
| curl -s <%= stage_done_url("finished") %> |
There was a problem hiding this comment.
This looks like a duplicate of ubuntu.task/os_boot.erb. Why move it into the storing of IP?
There was a problem hiding this comment.
this stage is the last one, by adding this I got all the stages to run and the nodes get registered.
There was a problem hiding this comment.
I would expect a "finished" log message to be reported to the server already, via this in os_boot.erb (which renders this file):
<%= render_template("store_ip") %>
<%= render_template("os_complete") %>
# Send final state
curl -s <%= stage_done_url("finished") %>
Is that last "finished" message not showing up?
There was a problem hiding this comment.
my mistake, i removed the os_boot.erb file
|
Thank you for the pull request! I've added some comments to get this in shape. Overall it is more likely to be accepted if the commit description can call out specifics on what is changing, and why. |
tasks/ubuntu/bionic.task/os_boot.erb
Outdated
| <%= render_template("os_complete") %> | ||
|
|
||
| # Send final state | ||
| curl -s <%= stage_done_url("os_boot") %> |
There was a problem hiding this comment.
the one inherited is sending the finished message not specifying the state.
is "finished" ok in this case?
There was a problem hiding this comment.
Specifying the state, you mean stating that the task is finished?
|
Waiting for CLA signature by @rngkll @rngkll - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
* Modifies stages to get the ubuntu 18.04 nodes to register. * Changes startup method after first boot to use cron. fix for PR based on comments
|
CLA signed by all contributors. |
|
@smcclellan I did some changes based on your comments, let me know if this helps. Thanks, |
|
any update on this one ? |
I fairly don't remember if I signed or not, I think I did because I have no problem with signing the CLA. I never did the test with other debian based or debian, but it should work, in some time, I'll use razor server again and will like to test them. https://cla.puppet.com/ is not available, can someone point me to the new link. |
|
FYI I'm no longer involved with Razor, and not sure entirely who the POC for the product is now. @mcdonaldseanp may know perhaps? |
Adds adds and modifies stages to get the ubuntu 18.04 nodes
to register.