This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Fix event ordering #332
Open
Fix event ordering #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcclellan
force-pushed
the
events-ordering
branch
5 times, most recently
from
7c7b9cf to
30724bd
Compare
added 2 commits
December 12, 2015 04:21
Facts, whether events, node log, hook log, or commands, were counter- intuitively ordered. This commit puts the latest entry at the bottom, which should be most useful. Additionally, whenever a limited "fact" collection is requested, it will limit from the bottom up. This means `razor events --limit 5` will show the 5 most recent events, with the most recent at the bottom. Fixes https://tickets.puppetlabs.com/browse/RAZOR-734
The commands collection, which can grow quite lengthy, currently does not allow any pagination. This provides the "start" and "limit" query arguments, which are present for many other collections.
smcclellan
force-pushed
the
events-ordering
branch
from
30724bd to
db39945
Compare
| if params[:start].nil? and params[:limit] and !total.nil? | ||
| # We have a request for a limited list of facts without a starting | ||
| # value. Take from the end so the latest entries are included. | ||
| params[:start] = [total - params[:limit], 0].max |
There was a problem hiding this comment.
This may be considered a break of the API. Probably a better way to deal with this is to add metadata properties to the previous endpoint or something. I'm not clear on the best approach here.
|
CLA signed by all contributors. |
|
Scott McClellan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
Scott McClellan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facts, whether events, node log, hook log, or commands, were counter-
intuitively ordered. This commit puts the latest entry at the bottom,
which should be most useful.
Additionally, whenever a limited "fact" collection is requested, it will
limit from the bottom up. This means
razor events --limit 5will show the 5most recent events, with the most recent at the bottom.
Fixes https://tickets.puppetlabs.com/browse/RAZOR-734