This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Prefetch subnets info in one call - quite big performance boost #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of lots of resources
Closed
|
@stepanstipl thanks for this example, that's perfect. I've got a pretty good test environment setup for this so I'm more than happy to fix up the tests and the like. I'm travelling the next few weeks but I'll update this issue when I get time to implement this. Thanks again. |
|
Hi @stepanstipl. Just a quick update. I've taken this pattern and run with it in #102, which also contains a number of other improvements. I'll close this PR in favour of that, but thanks again for testing this out and suggesting the change. |
|
Cool, great, I'll have a look and give #102 a go and see how it looks for us, cheers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped me with issue #144 when when i was hitting
Request limit exceedederror after couple of minutes (our env is quite big - 1k+ instances in given region). Now it seems to work as expected and finish in about 10 seconds in this environment (I was trying just to list resources withpuppet resource ec2_instancecommand).This should be properly tested though as I don't have environment to do so. Currently 3 VCR test will fail (1 of those used to fail for me even before my change), which I guess is expected, and I'm unable to run beaker tests currently (don't have AWS environment ready for it).