List imports explicitly in readme examples #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
reviewed
Sep 2, 2023
readme.md
Outdated
| import { When } from 'pundit' | ||
| import PostPolicy from 'src/policies/post.policy.js' | ||
|
|
||
| ... |
There was a problem hiding this comment.
what about
// ...instead?
There was a problem hiding this comment.
Good idea - makes it clearer that it is not code. Updated.
There was a problem hiding this comment.
I've also added return () around the JSX elements so it's a bit clearer when the JavaScript ends and the JSX elements start.
chrisalley
force-pushed
the
list-imports-explicitly-in-readme
branch
from
77906cc
to
c81f4e1
Compare
chrisalley
force-pushed
the
list-imports-explicitly-in-readme
branch
from
c81f4e1
to
012eb2f
Compare
tagliala
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.