Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom app directory location #333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

farski
Copy link

@farski farski commented Mar 9, 2023

There are several spots in the README that talk about the what the default puma-dev directory is (e.g., "~/.puma-dev by default", "Puma-dev will startup by default using the directory ~/.puma-dev"), but there wasn't any indication of how to change the directory to anything other than that default value.

I poked around the code a bit. I've never worked with Go, but as best I could tell that directory was hardcoded. I took a stab at adding the ability to set a custom directory with an environment variable.

I tried to lint and build the changes locally, but something is clearly banged up with my local Go setup. If what I came up with isn't correct, I doubt I would be able to fix it in the amount of time I have to spend on this, but it seemed like a simple change so hopefully it's close and maybe someone else can polish it up if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant