Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -listen-address and -install-listen-address flags for macOS #322

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tcannonfodder
Copy link

This could solve the issues outlined in #306, where users want to specify the addresses they listen to on puma-dev.

-listen-address defaults to 127.0.0.1, and -install-listen-address to keep existing behavior.

NOTE: these do not have tests yet, this is my first attempts at working in Go, so it's a starting point and definitely needs reviewed

* In order to allow foreground instances of `puma-dev` on macOS to
	specify what addresses to listen to, there needs to be a command-line
	argument that can be used to specify what address the socket should
	listen on
* This allows users to customize how the service should be installed,
	defaulting to the current behavior of `0.0.0.0` for compatability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants