-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document cron job for workflow updates #240
Conversation
@danielrbradley please especially verify that the token instructions are correct. cc @ringods for 👀 as well. |
Does the PR have any schema changes?Found 1 breaking change: Functions
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 167 167
=====================================
Misses 167 167 ☔ View full report in Codecov by Sentry. |
SETUP.md
Outdated
|
||
The Workflow will open a pull request so you can review the changes, make adjustments to your `.ci-mgmt.yaml` config file, and merge. | ||
|
||
We recommend setting `PULUMI_PROVIDER_AUTOMATION_TOKEN` to a token with Write scope permissions on your repository so that acceptance tests run on these automated pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guineveresaenger to avoid confusion, I would list exactly what is needed. If people only would set contents: write
permission on the repo, that would not be enough. It also requires pull-requests: write
permission.
Below is an image of how my token for Pulumiverse providers is setup for my fine grained Github access token.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that's a nice step forward in the explaining the process. Ringo's suggestion on the token permissions is a good one to include too as it would be very easy to produce a non-working token.
Fixes #237.