Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cron job for workflow updates #240

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

guineveresaenger
Copy link
Contributor

Fixes #237.

@guineveresaenger
Copy link
Contributor Author

@danielrbradley please especially verify that the token instructions are correct.

cc @ringods for 👀 as well.

Copy link

github-actions bot commented Feb 26, 2025

Does the PR have any schema changes?

Found 1 breaking change:

Functions

  • 🔴 "xyz:index/dataSource:DataSource" missing

New functions:

  • index/getDataSource.getDataSource

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d050581) to head (3383d94).
Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #240   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        167     167           
=====================================
  Misses       167     167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SETUP.md Outdated

The Workflow will open a pull request so you can review the changes, make adjustments to your `.ci-mgmt.yaml` config file, and merge.

We recommend setting `PULUMI_PROVIDER_AUTOMATION_TOKEN` to a token with Write scope permissions on your repository so that acceptance tests run on these automated pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guineveresaenger to avoid confusion, I would list exactly what is needed. If people only would set contents: write permission on the repo, that would not be enough. It also requires pull-requests: write permission.

https://github.com/pulumi/pulumi-tf-provider-boilerplate/blob/main/.github/workflows/resync-build.yml#L10-L11

Below is an image of how my token for Pulumiverse providers is setup for my fine grained Github access token.

Screenshot 2025-02-26 at 08 17 13

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's a nice step forward in the explaining the process. Ringo's suggestion on the token permissions is a good one to include too as it would be very easy to produce a non-working token.

@guineveresaenger guineveresaenger enabled auto-merge (squash) February 26, 2025 19:31
auto-merge was automatically disabled February 27, 2025 17:30

Pull request was closed

@guineveresaenger guineveresaenger merged commit 2c3a25e into main Feb 27, 2025
35 of 39 checks passed
@guineveresaenger guineveresaenger deleted the guin/document-ci-mgmt branch February 27, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document update automation process
3 participants