Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the instructions for bridging non sdkv2 providers #121

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Apr 19, 2024

The new instructions walk you through how to setup xyz.New(version.Version)() at the point where it is used. This will hopefully be clearer to our users.

Fixes #116
Fixes #119

@iwahbe iwahbe requested review from guineveresaenger, VenelinMartinov and a team April 19, 2024 13:57
@iwahbe iwahbe self-assigned this Apr 19, 2024
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 19, 2024
The new instructions walk you through how to setup `xyz.New(version.Version)()` at the
point where it is used. This will hopefully be clearer to our users.
@iwahbe iwahbe force-pushed the iwahbe/improve-instructions-for-non-sdkv2-providers branch from 00aea3d to 604af45 Compare April 19, 2024 14:02
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO harm done here but I'm not sure this is the right place? I'm starting to think we need to move toward "show, don't tell" as users are very busy. Drop boilerplates, make a pulumi CLI extension that bridges the provider and populates the right bits with minimal code, comments should be really pointers to ref docs or even doc comments but on the definition of P here.

@iwahbe
Copy link
Member Author

iwahbe commented Apr 19, 2024

NO harm done here but I'm not sure this is the right place? I'm starting to think we need to move toward "show, don't tell" as users are very busy. Drop boilerplates, make a pulumi CLI extension that bridges the provider and populates the right bits with minimal code, comments should be really pointers to ref docs or even doc comments but on the definition of P here.

I agree, and that is #100. Updating the boilerplate is faster as a temporary measure.

@iwahbe iwahbe merged commit 4d50aff into main Apr 19, 2024
2 checks passed
@iwahbe iwahbe deleted the iwahbe/improve-instructions-for-non-sdkv2-providers branch April 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how to specify the terraform provider during the bridging process tfgen fails to build provider
2 participants