Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross test ensure bitstream consumed #1996

Closed
wants to merge 3 commits into from
Closed

Cross test ensure bitstream consumed #1996

wants to merge 3 commits into from

Conversation

VenelinMartinov
Copy link
Contributor 

[rapid] flaky test, can not reproduce a failure
        Traceback (group did not use any data from bitstream; this is likely a result of Custom generator not calling any of the built-in generators):

rapid wants us to always consume from the random bitstream but we don't do that when we generate empty collection values. This just adds some generators in those cases so that rapid doesn't panic.

Also revert the depth off by one error - that was intentional since SingleNestedBlocks give one additional level of nesting.

@VenelinMartinov
Copy link
Contributor Author

superseded by #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VenelinMartinov VenelinMartinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VenelinMartinov