use accurate bridge preview flag for all diff tests

pulumi · Nov 25, 2024 · fcb17da · fcb17da
1 parent e0e1b42
commit fcb17da
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 9 deletions.
diff --git a/pkg/pf/tests/genrandom_test.go b/pkg/pf/tests/genrandom_test.go
@@ -48,6 +48,7 @@ func TestGenRandom(t *testing.T) {
 
 		t.Run(trace, func(t *testing.T) {
 			p := testprovider.RandomProvider()
+			p.EnableAccurateBridgePreview = true
 			server, err := newProviderServer(t, p)
 			require.NoError(t, err)
 			testutils.ReplayFile(t, server, trace)

diff --git a/pkg/pf/tests/genupdate_test.go b/pkg/pf/tests/genupdate_test.go
@@ -34,7 +34,9 @@ func TestGenUpdates(t *testing.T) {
 	t.Parallel()
 	trace := "testdata/updateprogram.json"
 
-	server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
+	info := testprovider.SyntheticTestBridgeProvider()
+	info.EnableAccurateBridgePreview = true
+	server, err := newProviderServer(t, info)
 	require.NoError(t, err)
 	testutils.ReplayFile(t, server, trace)
 }
diff --git a/pkg/pf/tests/internal/cross-tests/diff.go b/pkg/pf/tests/internal/cross-tests/diff.go
@@ -109,7 +109,7 @@ func Diff(t T, res pb.Resource, tfConfig1, tfConfig2 map[string]cty.Value, optio
 	require.NoError(t, err)
 	t.Logf("Pulumi.yaml:\n%s", string(bytes))
 
-	pt, err := pulcheck.PulCheck(t, bridgedProvider(prov), string(bytes))
+	pt, err := pulcheck.PulCheck(t, bridgedProvider(prov, bridgedProviderOpts{enableAccurateBridgePreview: true}), string(bytes))
 	require.NoError(t, err)
 	pt.Up(t)
 

diff --git a/pkg/pf/tests/internal/cross-tests/util.go b/pkg/pf/tests/internal/cross-tests/util.go
@@ -58,14 +58,19 @@ func skipUnlessLinux(t T) {
 	}
 }
 
-func bridgedProvider(prov *providerbuilder.Provider) info.Provider {
+type bridgedProviderOpts struct {
+	enableAccurateBridgePreview bool
+}
+
+func bridgedProvider(prov *providerbuilder.Provider, opts bridgedProviderOpts) info.Provider {
 	shimProvider := tfbridge.ShimProvider(prov)
 
 	provider := tfbridge0.ProviderInfo{
-		P:            shimProvider,
-		Name:         prov.TypeName,
-		Version:      prov.Version,
-		MetadataInfo: &tfbridge0.MetadataInfo{},
+		P:                           shimProvider,
+		Name:                        prov.TypeName,
+		Version:                     prov.Version,
+		MetadataInfo:                &tfbridge0.MetadataInfo{},
+		EnableAccurateBridgePreview: opts.enableAccurateBridgePreview,
 	}
 
 	provider.MustComputeTokens(tokens.SingleModule(prov.TypeName, "index", tokens.MakeStandard(prov.TypeName)))

diff --git a/pkg/pf/tests/provider_diff_test.go b/pkg/pf/tests/provider_diff_test.go
@@ -56,7 +56,9 @@ func TestEmptyTestresDiff(t *testing.T) {
 // Test removing an optional input.
 func TestOptionRemovalTestresDiff(t *testing.T) {
 	t.Parallel()
-	server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
+	info := testprovider.SyntheticTestBridgeProvider()
+	info.EnableAccurateBridgePreview = true
+	server, err := newProviderServer(t, info)
 	require.NoError(t, err)
 	testCase := `
         {
@@ -270,7 +272,9 @@ func TestSetNestedObjectAdded(t *testing.T) {
 
 func TestSetNestedObjectAddedOtherDiff(t *testing.T) {
 	t.Parallel()
-	server, err := newProviderServer(t, testprovider.SyntheticTestBridgeProvider())
+	info := testprovider.SyntheticTestBridgeProvider()
+	info.EnableAccurateBridgePreview = true
+	server, err := newProviderServer(t, info)
 	require.NoError(t, err)
 	testCase := `
         {