Fix build #782
Merged
Fix build #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
added
the
impact/no-changelog-required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 50.19% 50.16% -0.03%
==========================================
Files 30 30
Lines 4210 4212 +2
==========================================
Hits 2113 2113
- Misses 1910 1912 +2
Partials 187 187 ☔ View full report in Codecov by Sentry. |
mjeffryes
approved these changes
Jan 2, 2025
blampe
added a commit
that referenced
this pull request
Jan 2, 2025
I kicked off some updates (via #755) for some k8s dependencies last month: * #769 * #768 * #767 Tests failed on those due to some of our binaries installed via `make` being out of sync with the bumps. As it turns out we also weren't requiring any status checks, so those PRs merged with failing tests. This PR fixes the build by bumping corresponding dependencies in our Makefile and regenerating types. I've also added required checks to the repo: "Build", "E2E Tests", and "Unit Tests". Fixes #778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kicked off some updates (via #755) for some k8s dependencies last month:
Tests failed on those due to some of our binaries installed via
makebeing out of sync with the bumps.As it turns out we also weren't requiring any status checks, so those PRs merged with failing tests.
This PR fixes the build by bumping corresponding dependencies in our Makefile and regenerating types.
I've also added required checks to the repo: "Build", "E2E Tests", and "Unit Tests".
Fixes #778