Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cleanup of Stack in foreground deletion #760

Merged
merged 7 commits into from
Nov 27, 2024

use constants

d1085c8
Select commit
Loading
Failed to load commit list.
Merged

Ensure cleanup of Stack in foreground deletion #760

use constants
d1085c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 27, 2024 in 0s

50.19% (-0.53%) compared to 09f8484

View this Pull Request on Codecov

50.19% (-0.53%) compared to 09f8484

Details

Codecov Report

Attention: Patch coverage is 28.98551% with 49 lines in your changes missing coverage. Please review.

Project coverage is 50.19%. Comparing base (09f8484) to head (d1085c8).

Files with missing lines Patch % Lines
...ator/internal/controller/auto/update_controller.go 14.28% 24 Missing ⚠️
...tor/internal/controller/pulumi/stack_controller.go 53.33% 8 Missing and 6 partials ⚠️
operator/internal/controller/auto/utils.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   50.71%   50.19%   -0.53%     
==========================================
  Files          30       30              
  Lines        4180     4210      +30     
==========================================
- Hits         2120     2113       -7     
- Misses       1876     1910      +34     
- Partials      184      187       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov