Add the serviceAccountName field to Stack.spec #723
Merged
+921
−777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
commented
Oct 17, 2024
| @@ -44,7 +44,7 @@ spec: | |||
| - --leader-elect | |||
| - --health-probe-bind-address=:8081 | |||
| - --program-fs-adv-addr=pulumi-kubernetes-operator.$(POD_NAMESPACE).svc.cluster.local:80 | |||
| - --zap-log-level=error | |||
| - --zap-log-level=info | |||
There was a problem hiding this comment.
Slipped in this fix, is now consistent with Helm chart and is more useful at info level.
EronWright
added
the
impact/no-changelog-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #723 +/- ##
==========================================
+ Coverage 50.01% 50.04% +0.03%
==========================================
Files 30 30
Lines 4055 4058 +3
==========================================
+ Hits 2028 2031 +3
Misses 1843 1843
Partials 184 184 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a top-level
serviceAccountNameto the Stack spec, since it is practically a required element for every stack.Note that the
workspaceTemplatewould take precedence.The Workspace applies the default value of
defaultif none is specified.Side-effect: some outdated manifests were regenerated.
Related issues (optional)
Closes #720