[V2] Set default statefulset image based on securityProfile #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
added
the
impact/no-changelog-required
rquitales
force-pushed
the
rquitales/default-image
branch
from
f160fbe to
c2ce13e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #693 +/- ##
==========================================
+ Coverage 49.11% 49.28% +0.17%
==========================================
Files 26 26
Lines 2877 2887 +10
==========================================
+ Hits 1413 1423 +10
Misses 1287 1287
Partials 177 177 ☔ View full report in Codecov by Sentry. |
blampe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This update removes the default CRD validation marker from the
workspace.spec.imagefield, allowing for dynamic image selection based on the value ofworkspace.spec.securityProfile. WhensecurityProfileis set tobaseline, the image defaults topulumi/pulumi:latest. IfsecurityProfileis marked asrestricted, the system will instead selectpulumi/pulumi:latest-nonroot. If a user specifies their own image, then that value is used instead. Handling these default settings within the controller is necessary, as CRD validation markers cannot accommodate conditional defaults.Before implementing this feature, additional ginkgo tests were introduced to confirm that the desired behavior is properly achieved.
Related issues (optional)
Closes: #653