Simplified deployment app #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
commented
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #691 +/- ##
==========================================
- Coverage 49.28% 49.23% -0.06%
==========================================
Files 26 26
Lines 2887 2890 +3
==========================================
Hits 1423 1423
- Misses 1287 1290 +3
Partials 177 177 ☔ View full report in Codecov by Sentry. |
blampe
added
the
impact/no-changelog-required
rquitales
reviewed
Sep 26, 2024
rquitales
approved these changes
Sep 26, 2024
EronWright
force-pushed
the
issue-684-pt2
branch
from
f955d0f to
290e25b
Compare
blampe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a new, simplified deployment app for PKO. It leverages the kustomization that is maintained in
operator/config/defaultto avoid code duplication. It supports ONLY cluster-wide installation.PKOv2 is designed to natively support multi-tenancy across namespaces without needing to deploy separate instances of the operator into each namespace. Looking back at #328, we see that the ability to deploy to multiple namespaces was added to address a lack of isolation (see https://github.com/pulumi/home/issues/2330). I opened #690 to track adding support for single-namespace deployment.
Related issues (optional)