[v2] Stable envRefs #678
Merged
[v2] Stable envRefs #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
added
the
impact/no-changelog-required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #678 +/- ##
=======================================
Coverage 33.24% 33.25%
=======================================
Files 25 25
Lines 3949 3951 +2
=======================================
+ Hits 1313 1314 +1
- Misses 2474 2475 +1
Partials 162 162 ☔ View full report in Codecov by Sentry. |
blampe
commented
Sep 20, 2024
Comment on lines
-94
to
-96
| t.Cleanup(func() { | ||
| _ = run(exec.Command("kubectl", "delete", "-f", "e2e/testdata/git-auth-nonroot")) | ||
| }) |
There was a problem hiding this comment.
This was deleting the secret needed by the operator in order to poll the repo, preventing the stack from reconciling / getting deleted.
blampe
force-pushed
the
blampe/v2-envvars
branch
from
88fabad to
be10198
Compare
EronWright
approved these changes
Sep 23, 2024
blampe
added a commit
that referenced
this pull request
Sep 24, 2024
Stack CRDs that include `envRefs` will currently thrash the workspace's underlying StatefulSet because map order is undefined. This sorts the envRef keys ahead of time to keep the StatefulSet stable. As a result we're also able to turn on the E2E test in CI since it should now succeed reliably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack CRDs that include
envRefswill currently thrash the workspace's underlying StatefulSet because map order is undefined.This sorts the envRef keys ahead of time to keep the StatefulSet stable. As a result we're also able to turn on the E2E test in CI since it should now succeed reliably.