-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set terminationGracePeriodSeconds for HelmCharts #520
Set terminationGracePeriodSeconds for HelmCharts #520
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @M1l1j0n,
thanks for the PR. Can you bump the minor version in the Chart.yaml
and add artifacthub.io/changes:
text?
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@M1l1j0n, can you give me rights to push on your branch? I need to update the README.md
Or could you call this command: helm-docs -t README.md.gotmpl -o README.md -b for-the-badge
with the helm-docs
cli?
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @M1l1j0n,
thanks for your contribution and lgtm!
Proposed changes
We would like to override value of terminationGracePeriodSeconds parameter. Unfortunately pulumi kubernetes operator helm chart is not setting this value.
Related issues (optional)
By default, the terminationGracePeriodSeconds parameter is not set, so the operator will take no action. If this parameter is set then the value will be overwritten.
impact/no-changelog-required