Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set terminationGracePeriodSeconds for HelmCharts #520

Conversation

M1l1j0n
Copy link
Contributor

@M1l1j0n M1l1j0n commented Nov 9, 2023

Proposed changes

We would like to override value of terminationGracePeriodSeconds parameter. Unfortunately pulumi kubernetes operator helm chart is not setting this value.

Related issues (optional)

By default, the terminationGracePeriodSeconds parameter is not set, so the operator will take no action. If this parameter is set then the value will be overwritten.

impact/no-changelog-required

Copy link

github-actions bot commented Nov 9, 2023

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M1l1j0n,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

deploy/helm/pulumi-operator/values.yaml Outdated Show resolved Hide resolved
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@M1l1j0n
Copy link
Contributor Author

M1l1j0n commented Nov 13, 2023

Done @dirien

Hey @M1l1j0n,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

@M1l1j0n M1l1j0n requested a review from dirien November 13, 2023 11:46
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M1l1j0n, can you give me rights to push on your branch? I need to update the README.md

Or could you call this command: helm-docs -t README.md.gotmpl -o README.md -b for-the-badge with the helm-docs cli?

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@M1l1j0n
Copy link
Contributor Author

M1l1j0n commented Nov 16, 2023

@dirien I have called helm-docs command.

@M1l1j0n, can you give me rights to push on your branch? I need to update the README.md

Or could you call this command: helm-docs -t README.md.gotmpl -o README.md -b for-the-badge with the helm-docs cli?

@M1l1j0n M1l1j0n requested a review from dirien November 16, 2023 13:31
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M1l1j0n,

thanks for your contribution and lgtm!

@dirien dirien merged commit 6b391f9 into pulumi:master Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants