Skip to content

Commit

Permalink
Make permalink missing log entry for refresh less scary (#352)
Browse files Browse the repository at this point in the history
* Make permalink missing log entry for refresh less scary

Apply the same fix as #288 to the refresh path as well.

* Mention log de-escalation in changelog

Co-authored-by: Michael Bridgen <[email protected]>
  • Loading branch information
lukehoban and squaremo authored Oct 25, 2022
1 parent c701af1 commit daeeee7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ CHANGELOG
- Give an example of using this operator with a Flux GitRepository and webhooks, in
`examples/flux-source`.
[#339](https://github.com/pulumi/pulumi-kubernetes-operator/pull/339)
- De-escalate a log message about a harmless error from ERROR to DEBUG
[#352](https://github.com/pulumi/pulumi-kubernetes-operator/pull/352)

## 1.10.0 (2022-10-21)

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/stack/stack_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,7 @@ func (sess *reconcileStackSession) RefreshStack(ctx context.Context, expectNoCha
p, err := auto.GetPermalink(result.StdOut)
if err != nil {
// Successful update but no permalink suggests a backend which doesn't support permalinks. Ignore.
sess.logger.Error(err, "No permalink found.", "Namespace", sess.namespace)
sess.logger.Debug("No permalink found - ignoring.", "Stack.Name", sess.stack.Stack, "Namespace", sess.namespace)
}
permalink := shared.Permalink(p)
return permalink, nil
Expand Down

0 comments on commit daeeee7

Please sign in to comment.