Add a test for canceling resources with a timeout #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was answering #261 (comment), I was looking at our implementation of `Cancel`. I noticed there wasn't a test for this edge case, and added one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 36 36
Lines 4955 4955
=======================================
Hits 3396 3396
Misses 1291 1291
Partials 268 268 ☔ View full report in Codecov by Sentry. |
thomas11
approved these changes
Feb 28, 2025
| // Test that a `Cancel` call will cancel in-flight operations, even if they already have a | ||
| // timeout associated with them. | ||
| // | ||
| // Main routine Server routine Cancel routine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was answering #261 (comment), I was looking at our implementation of
Cancel. I noticed there wasn't a test for this edge case, and added one.