Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with .NET 9.0 #386

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Run tests with .NET 9.0 #386

wants to merge 2 commits into from

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Nov 13, 2024

Add .NET 9.0 to the CI test matrix

@julienp julienp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 13, 2024
@julienp
Copy link
Contributor Author

julienp commented Nov 15, 2024

Getting an error due to extra output that causes the port parsing to fail:

error: testprovider (resource) plugin [D:\a\pulumi-dotnet\pulumi-dotnet\integration_tests\testprovider\pulumi-resource-testprovider.exe] wrote a non-numeric port to stdout ('0'): strconv.Atoi: parsing "\x1b]9;4;3;\x1b\\\x1b]9;4;0;\x1b\\49365": invalid syntax

The port is written here

stdout.Write(port.ToString() + "\n");

Interestingly, when I changed that line to be stdout.Write("banana" + port.ToString() + "\n");, I got the expected output and no ansi escape codes.

This only happens on .NET 9, and only in CI.

@julienp
Copy link
Contributor Author

julienp commented Nov 15, 2024

@Frassle found the issue dotnet/msbuild#10998

@julienp
Copy link
Contributor Author

julienp commented Nov 15, 2024

Workaround in CLI pulumi/pulumi#17783

Once that's released, we can do the upgrade here.

Update the dependencies to be able to compile on 9.0
@julienp julienp force-pushed the julienp/dotnet-9.0 branch from e8850d8 to fec2e3f Compare January 16, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant