Fix passing of env variables to docker build (#310)

pulumi · Nov 3, 2021 · 50c41eb · 50c41eb
1 parent 0a6928e
commit 50c41eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,5 @@
 ## HEAD (Unreleased)
-_(none)_
+* Fix passing of `env` parameter in `docker.DockerBuildArgs` in the Python SDK [#310](https://github.com/pulumi/pulumi-docker/issues/310)
 
 ---
 

diff --git a/sdk/python/pulumi_docker/docker.py b/sdk/python/pulumi_docker/docker.py
@@ -655,7 +655,9 @@ def run_command_that_can_fail(
     cmd.extend(args)
 
     if env is not None:
-        env = os.environ.copy().update(env)
+        environ = os.environ.copy()
+        environ.update(env)
+        env = environ
 
     process = subprocess.Popen(cmd, env=env, stdout=subprocess.PIPE,
                                stderr=subprocess.PIPE, stdin=subprocess.PIPE, encoding="utf-8")