Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a providers build environment image #112

Merged

Conversation

christophermaier
Copy link
Contributor

Adds a new build-environment target to the all-in-one Pulumi Dockerfile, which adds pulumictl, golangci-lint, and goreleaser to encapsulate the tools needed to build a Terraform-boilerplate-based Pulumi provider, as laid out in
https://github.com/pulumi/pulumi-tf-provider-boilerplate.

Fixes
#111 (see that issue for further background and rationale).

Signed-off-by: Christopher Maier [email protected]

Adds a new `build-environment` target to the all-in-one Pulumi
Dockerfile, which adds `pulumictl`, `golangci-lint`, and `goreleaser`
to encapsulate the tools needed to build a Terraform-boilerplate-based
Pulumi provider, as laid out in
https://github.com/pulumi/pulumi-tf-provider-boilerplate.

Fixes
pulumi#111 (see
that issue for further background and rationale).

Signed-off-by: Christopher Maier <[email protected]>
@christophermaier
Copy link
Contributor Author

I'm not sure how you'd like to manage the test and release process for
this new image; I took an educated guess based on the current
workflows, but would appreciate a review by someone more familiar with
this release process.

@christophermaier
Copy link
Contributor Author

@RobbieMcKinstry Ping ☝️

@RobbieMcKinstry
Copy link
Contributor

Hey, very sorry for the slow reply on this. I'll get back to you soon; I'm juggling too many things at once right now. Again, my apologies, and thank you for your contribution.

@RobbieMcKinstry RobbieMcKinstry self-requested a review November 10, 2022 16:49
@RobbieMcKinstry RobbieMcKinstry added kind/enhancement Improvements or new features area/build labels Nov 16, 2022
Copy link
Contributor

@RobbieMcKinstry RobbieMcKinstry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Thanks so much for the PR!

@RobbieMcKinstry RobbieMcKinstry merged commit 90a7709 into pulumi:main Nov 16, 2022
@RobbieMcKinstry
Copy link
Contributor

@christophermaier Would you send me an email at [email protected]? I want to say thank you for your contribution and patience with a small gift from Pulumi. I appreciate the work you've done on this PR, and your persistence when my communication dropped off! Thanks again for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/enhancement Improvements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants